-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation using ansible #69
Installation using ansible #69
Conversation
incoming changes
this is the same pr as the older one. sorry for the new pr. in old pr I made a blunder. I tagged all the new changes so I have to make a new PR. I have closed the previous one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need couple of changes which can be taken in another PR
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but the Golang version change is needed.
|
||
```bash | ||
wget https://storage.googleapis.com/golang/go1.13.0.linux-amd64.tar.gz | ||
tar -C /usr/local -xzf go1.12.1.linux-amd64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect version of Golang.
<br /> Install golang | ||
|
||
```bash | ||
wget https://storage.googleapis.com/golang/go1.13.0.linux-amd64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if this is the correct version. I think the latest stable version is
https://dl.google.com/go/go1.13.12.linux-amd64.tar.gz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raised #74
# Do you need to install or clean up telemetry tools? | ||
enable_telemetry_tools: false | ||
``` | ||
<br /> How to enable Orchestration installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: These are subheadings. Please make them #### or ### depending on the nesting.
# Install Orchestration Manager (true/false) | ||
enable_orchestration: false | ||
``` | ||
<br /> Set HOST_IP environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: These are subheadings. Please make them #### or ### depending on the nesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @ravisaxena23
This was really helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congrats @ravisaxena23 your first PR is getting merged. I hope you continue your contributions in Open Source. All the best.
What type of PR is this?
What this PR does / why we need it:
this PR add the documentation for installing local cluster using ansible. we are going to remove wiki hence we need it.
Test Report Added?:
Special notes for your reviewer: