Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve type inference for chain function #370

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

fResult
Copy link
Contributor

@fResult fResult commented Dec 4, 2023

Description

Please provide a detailed description of the changes and the intent behind them :)

Checklist

  • Changes are covered by tests if behaviour has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

For the issue #339 - chain function can't infer data type
Display type inference when using chain function

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 2:59am

@fResult fResult force-pushed the fix/chain-fn-type-inference branch from 285ea00 to 2002604 Compare December 4, 2023 10:56
@fResult fResult force-pushed the fix/chain-fn-type-inference branch from 2002604 to 4c2ede2 Compare December 4, 2023 10:58
@fResult fResult force-pushed the fix/chain-fn-type-inference branch from 4c2ede2 to 076ba5f Compare December 4, 2023 11:00
@fResult fResult force-pushed the fix/chain-fn-type-inference branch from 076ba5f to b85860c Compare December 5, 2023 05:06
@fResult fResult force-pushed the fix/chain-fn-type-inference branch from b85860c to 72f5acf Compare December 5, 2023 05:17
@fResult fResult force-pushed the fix/chain-fn-type-inference branch from 72f5acf to 616faee Compare December 5, 2023 05:23
@fResult fResult force-pushed the fix/chain-fn-type-inference branch from 616faee to f6e0763 Compare December 5, 2023 05:27
@fResult fResult force-pushed the fix/chain-fn-type-inference branch from f6e0763 to 46a6e9c Compare December 5, 2023 05:32
sodiray
sodiray previously approved these changes Feb 21, 2024
Copy link
Owner

@sodiray sodiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fResult 🙏

@sodiray sodiray merged commit caf1a86 into sodiray:master Feb 21, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants