Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some included libs are missing provenances and licenses #403

Closed
joelb123 opened this issue Feb 4, 2021 · 5 comments
Closed

some included libs are missing provenances and licenses #403

joelb123 opened this issue Feb 4, 2021 · 5 comments

Comments

@joelb123
Copy link

joelb123 commented Feb 4, 2021

It's good practice to indicate versions and origins (repository URLs and web sites) of included libraries. Several libraries are missing license files, which may violate the usage terms in many cases.

@martin-steinegger
Copy link
Member

martin-steinegger commented Feb 5, 2021

Thank you for looking into it. What libraries are missing a license?
Debian made a list of libs and copyrights:
https://salsa.debian.org/med-team/mmseqs2/-/blob/master/debian/copyright

@milot-mirdita
Copy link
Member

Which library is missing licenses? I think everything not developed by us should be prefixed by the respective license. I would strongly recommend to not split away any library we bundle (except maybe zstd, as Debian is doing). We occasionally change stuff (e.g. I rewrote microtar completely, to fit our needs, maybe I should move it to commons now).\

We could add a module (mmseqs licenses?) that lists all libraries used and their licenses, or maintain our own version of debian's copyright file.

@joelb123
Copy link
Author

joelb123 commented Feb 9, 2021

Adding a module doesn't meet most common license terms that require redistribution of copyrights. You know your libraries better than I do, but the directories in lib/ that are missing licenses and readmes are alp/, cacode/, gzstream/, ksw2/, simd/, and xxhash/. Libs that you have edited, like microtar, should have a readme indicating you have done so.

@milot-mirdita
Copy link
Member

I added missing the missing licenses. lib/simd is developed by us, it's just at this location for convenience as we occasionally sync it with HHsuite (https://github.com/soedinglab/hh-suite).

@joelb123
Copy link
Author

Thanks, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants