Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility not met message #1223

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1223 (207b1b3) into 3.x (b8593ea) will increase coverage by 0.19%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##                3.x    #1223      +/-   ##
============================================
+ Coverage     71.64%   71.84%   +0.19%     
- Complexity     1855     1864       +9     
============================================
  Files           260      260              
  Lines          7462     7465       +3     
  Branches        944      943       -1     
============================================
+ Hits           5346     5363      +17     
+ Misses         1636     1622      -14     
  Partials        480      480              
Files Changed Coverage Δ
...ay/sofa/boot/compatibility/VerificationResult.java 71.42% <76.92%> (+2.19%) ⬆️
...boot/compatibility/AbstractJarVersionVerifier.java 81.81% <100.00%> (ø)
...ot/compatibility/CompatibilityNotMetException.java 100.00% <100.00%> (ø)
.../compatibility/CompositeCompatibilityVerifier.java 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 3a21e03 into sofastack:3.x Aug 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants