Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize getBiz method by reduce invoke Map.toArray() (#1286) #1287

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

NTP1996
Copy link
Contributor

@NTP1996 NTP1996 commented Feb 2, 2024

使用getBizByClassLoader 方法替换getBizInOrder方法。减少 Map.toArray 调用次数,和冗余的排序操作;

Copy link

sofastack-cla bot commented Feb 2, 2024

Hi @NTP1996, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@NTP1996
Copy link
Contributor Author

NTP1996 commented Feb 3, 2024

@HzjNeverStop 帮忙 review 下,看是否 ok。解决 #1286 ,非常感谢。

@HzjNeverStop
Copy link
Contributor

@HzjNeverStop 帮忙 review 下,看是否 ok。解决 #1286 ,非常感谢。

修改方式没有问题,请修改测试用例 DynamicJvmServiceProxyFinderTests 以通过 CI

@NTP1996
Copy link
Contributor Author

NTP1996 commented Feb 19, 2024

@HzjNeverStop 帮忙 review 下,看是否 ok。解决 #1286 ,非常感谢。

修改方式没有问题,请修改测试用例 DynamicJvmServiceProxyFinderTests 以通过 CI

已修改

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c050784) 82.95% compared to head (ce9a380) 82.98%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1287      +/-   ##
============================================
+ Coverage     82.95%   82.98%   +0.02%     
- Complexity     2916     2925       +9     
============================================
  Files           330      330              
  Lines          9620     9625       +5     
  Branches       1164     1164              
============================================
+ Hits           7980     7987       +7     
  Misses         1131     1131              
+ Partials        509      507       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 3502092 into sofastack:master Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants