Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add component lifecycle support #318

Merged
merged 6 commits into from
Jan 9, 2019
Merged

add component lifecycle support #318

merged 6 commits into from
Jan 9, 2019

Conversation

straybirdzls
Copy link
Member

fix #290

@straybirdzls straybirdzls added the enhancement New feature or request label Dec 28, 2018
@straybirdzls straybirdzls self-assigned this Dec 28, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 674

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 74.694%
Totals Coverage Status
Change from base Build 664: 2.7%
Covered Lines: 1709
Relevant Lines: 2288
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 674

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 74.694%
Totals Coverage Status
Change from base Build 664: 2.7%
Covered Lines: 1709
Relevant Lines: 2288
💛 - Coveralls

@straybirdzls straybirdzls added this to the 2.6.0 milestone Dec 29, 2018
QilongZhang
QilongZhang reviewed Jan 2, 2019
View reviewed changes
...ofa-boot-starter/src/main/java/com/alipay/sofa/runtime/api/component/ComponentLifeCycle.java Outdated
void activate() throws ServiceRuntimeException;

/**
* Component lifecycle event occurred when component is activated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this typo, change activated as deactivated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

glmapper
glmapper approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@QilongZhang QilongZhang merged commit 2d9b90f into sofastack:2.x Jan 9, 2019
QilongZhang pushed a commit to QilongZhang/sofa-boot that referenced this pull request Jan 30, 2019
@straybirdzls @QilongZhang
Add component lifecycle support (sofastack#318)
db54334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongZhang QilongZhang QilongZhang approved these changes

@glmapper glmapper glmapper approved these changes

@caojie09 caojie09 caojie09 approved these changes

@ujjboy ujjboy Awaiting requested review from ujjboy

Assignees

@straybirdzls straybirdzls

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@straybirdzls @coveralls @QilongZhang @glmapper @caojie09