Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Healthcheck management fix #325

Merged
merged 7 commits into from
Jan 9, 2019
Merged

Healthcheck management fix #325

merged 7 commits into from
Jan 9, 2019

Conversation

straybirdzls
Copy link
Member

fix #313

@coveralls
Copy link

coveralls commented Dec 29, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 688

  • 24 of 27 (88.89%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 72.089%
Changes Missing Coverage Covered Lines Changed/Added Lines %
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java 13 16 81.25%
Files with Coverage Reduction New Missed Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/health/MultiApplicationHealthIndicator.java 2 43.75%
Totals Coverage Status
Change from base Build 664: 0.07%
Covered Lines: 1653
Relevant Lines: 2293
💛 - Coveralls

@straybirdzls straybirdzls self-assigned this Dec 29, 2018
@straybirdzls straybirdzls added the bug Something isn't working label Dec 29, 2018
@straybirdzls straybirdzls added this to the 2.6.0 milestone Dec 29, 2018
glmapper
glmapper approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caojie09 caojie09 merged commit fac6c51 into sofastack:2.x Jan 9, 2019
@QilongZhang QilongZhang mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongZhang QilongZhang QilongZhang approved these changes

@glmapper glmapper glmapper approved these changes

@caojie09 caojie09 caojie09 approved these changes

@ujjboy ujjboy Awaiting requested review from ujjboy

Assignees

@straybirdzls straybirdzls

Labels
bug Something isn't working
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@straybirdzls @coveralls @QilongZhang @glmapper @caojie09