Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix properties of integration: data.server.datumTimeToLiveSec should … #124

Merged

Conversation

atellwu
Copy link
Contributor

@atellwu atellwu commented Jun 9, 2020

Delete the wrongly submitted configuration: data.server.datumTimeToLiveSec=20

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/XS labels Jun 9, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #124 into master will decrease coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     62.86%   62.13%   -0.74%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15464    15464              
  Branches       1489     1489              
============================================
- Hits           9722     9609     -113     
- Misses         4722     4843     +121     
+ Partials       1020     1012       -8     
Impacted Files Coverage Δ Complexity Δ
.../registry/server/data/renew/DatumLeaseManager.java 45.45% <0.00%> (-40.50%) 0.00% <0.00%> (ø%)
...try/jraft/handler/RaftServerConnectionHandler.java 40.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
...registry/remoting/bolt/ConnectionEventAdapter.java 51.72% <0.00%> (-17.25%) 0.00% <0.00%> (ø%)
...sofa/registry/server/data/change/SnapshotData.java 90.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...egistry/server/meta/store/SessionStoreService.java 56.59% <0.00%> (-9.35%) 0.00% <0.00%> (ø%)
...istry/server/meta/registry/MetaServerRegistry.java 66.66% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...y/sofa/registry/server/data/change/ChangeData.java 58.33% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...rver/session/node/service/DataNodeServiceImpl.java 60.55% <0.00%> (-6.67%) 0.00% <0.00%> (ø%)
...sofa/registry/server/meta/store/RenewDecorate.java 73.68% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...ay/sofa/registry/server/data/cache/DatumCache.java 91.66% <0.00%> (-4.17%) 0.00% <0.00%> (ø%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b312c...92b16f3. Read the comment docs.

@dzdx dzdx merged commit 78b63a1 into sofastack:master Aug 3, 2020
nocvalight pushed a commit to nocvalight/sofa-registry that referenced this pull request Aug 23, 2020
…not set (sofastack#124)

Co-authored-by: kezhu.wukz <kezhu.wukz@alipay.com>
dzdx pushed a commit that referenced this pull request Dec 13, 2021
…not set (#124)

Co-authored-by: kezhu.wukz <kezhu.wukz@alipay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants