Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix temporary push bug #13

Merged
merged 8 commits into from
Apr 25, 2019
Merged

fix temporary push bug #13

merged 8 commits into from
Apr 25, 2019

Conversation

Synex-wh
Copy link
Contributor

Motivation:

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #3.

If there is no issue then describe the changes introduced by this PR.

Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #13 into master will increase coverage by 0.17%.
The diff coverage is 88.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #13      +/-   ##
===========================================
+ Coverage     58.72%   58.9%   +0.17%     
  Complexity       44      44              
===========================================
  Files           376     376              
  Lines         13061   13059       -2     
  Branches       1280    1283       +3     
===========================================
+ Hits           7670    7692      +22     
+ Misses         4510    4491      -19     
+ Partials        881     876       -5
Impacted Files Coverage Δ Complexity Δ
...ssion/scheduler/task/DataChangeFetchCloudTask.java 59.82% <100%> (+0.34%) 0 <0> (ø) ⬇️
...ry/server/session/scheduler/task/DataPushTask.java 51.08% <100%> (-1.65%) 0 <0> (ø)
...server/data/change/event/DataChangeEventQueue.java 86.36% <100%> (+1.06%) 0 <0> (ø) ⬇️
...gistry/server/data/bootstrap/DataServerConfig.java 64.1% <33.33%> (-0.81%) 0 <0> (ø)
...registry/server/data/change/DataChangeHandler.java 77.38% <83.33%> (-0.12%) 0 <0> (ø)
...r/session/scheduler/SessionThreadPoolExecutor.java 62.5% <0%> (-31.25%) 0% <0%> (ø)
...y/sofa/registry/server/data/change/ChangeData.java 58.33% <0%> (-8.34%) 0% <0%> (ø)
...a/registry/task/scheduler/TimedSupervisorTask.java 65.51% <0%> (-6.9%) 0% <0%> (ø)
...rver/session/bootstrap/SessionServerBootstrap.java 58.82% <0%> (+1.6%) 0% <0%> (ø) ⬇️
...ipay/sofa/registry/jraft/bootstrap/RaftClient.java 42.22% <0%> (+2.22%) 0% <0%> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2187157...5241284. Read the comment docs.

@Synex-wh Synex-wh merged commit 4e1cc58 into sofastack:master Apr 25, 2019
dzdx pushed a commit that referenced this pull request Dec 13, 2021
* fix temp push

* update version 5.2.1-SNAPSHOT

* fix test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

临时推送数据在合并推送逻辑存在问题
3 participants