Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change renew expired duration to 15s #145

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Conversation

dzdx
Copy link
Member

@dzdx dzdx commented Oct 16, 2020

requirements:
renew expired duration < sessionOff duration

@codecov-io
Copy link

Codecov Report

Merging #145 into master will decrease coverage by 0.20%.
The diff coverage is 42.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
- Coverage     62.25%   62.04%   -0.21%     
  Complexity       44       44              
============================================
  Files           429      437       +8     
  Lines         15505    15802     +297     
  Branches       1490     1502      +12     
============================================
+ Hits           9652     9804     +152     
- Misses         4840     4983     +143     
- Partials       1013     1015       +2     
Impacted Files Coverage Δ Complexity Δ
.../model/metaserver/ConfigureLoadbalanceRequest.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...model/metaserver/GetLoadbalanceMetricsRequest.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ry/common/model/metaserver/LoadbalanceMetrics.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...gistry/server/meta/bootstrap/MetaServerConfig.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../server/meta/node/impl/SessionNodeServiceImpl.java 33.07% <0.00%> (-23.69%) 0.00 <0.00> (ø)
...istry/server/meta/registry/MetaServerRegistry.java 61.11% <0.00%> (-5.56%) 0.00 <0.00> (ø)
...eta/remoting/connection/DataConnectionHandler.java 66.66% <ø> (ø) 0.00 <0.00> (ø)
...eta/remoting/connection/MetaConnectionHandler.java 15.00% <ø> (ø) 0.00 <0.00> (ø)
.../remoting/connection/SessionConnectionHandler.java 70.58% <ø> (ø) 0.00 <0.00> (ø)
.../server/meta/remoting/handler/DataNodeHandler.java 72.72% <ø> (ø) 0.00 <0.00> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2f105...4e61bb7. Read the comment docs.

Copy link
Member

@nocvalight nocvalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@quhongwei quhongwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzdx dzdx merged commit 38bae7d into sofastack:master Oct 16, 2020
dzdx added a commit that referenced this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants