Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload maven fix javadoc rules #330

Merged

Conversation

huanglongchao
Copy link
Contributor

Motivation:

Publish jar to maven central warehouse
Fix javadoc rules problem

Modification:

All are comments

Result:

Fixes #327

If there is no issue then describe the changes introduced by this PR.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #330 (bbb109b) into master (c9cbee4) will increase coverage by 0.15%.
The diff coverage is 82.80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
+ Coverage     76.40%   76.55%   +0.15%     
  Complexity       48       48              
============================================
  Files           493      495       +2     
  Lines         18249    18488     +239     
  Branches       1783     1802      +19     
============================================
+ Hits          13943    14154     +211     
- Misses         3502     3519      +17     
- Partials        804      815      +11     
Impacted Files Coverage Δ
...pay/sofa/registry/common/model/CommonResponse.java 100.00% <ø> (ø)
...m/alipay/sofa/registry/common/model/DataUtils.java 98.41% <ø> (ø)
...ay/sofa/registry/common/model/GenericResponse.java 100.00% <ø> (ø)
...va/com/alipay/sofa/registry/common/model/Node.java 66.66% <ø> (ø)
...pay/sofa/registry/common/model/PublisherUtils.java 92.85% <ø> (ø)
...ipay/sofa/registry/common/model/ServerDataBox.java 36.00% <ø> (ø)
...y/sofa/registry/common/model/dataserver/Datum.java 77.63% <ø> (ø)
...common/model/dataserver/GetDataVersionRequest.java 54.54% <ø> (ø)
...istry/common/model/metaserver/DataCenterNodes.java 100.00% <ø> (ø)
...mmon/model/metaserver/FetchProvideDataRequest.java 37.50% <ø> (ø)
... and 84 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb984a8...bbb109b. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 808b7dc into sofastack:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registry-test is not uploaded to maven central repository since 6.0.0
2 participants