Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sofa common util stringutil usage #332

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

khotyn
Copy link
Member

@khotyn khotyn commented Jul 6, 2023

Using apache common-langs StringUtils instead of sofa-common-util's StringUtil under profile package, sofa-common-utils's StringUtil under profile package is removed from newer sofa-common-util version.

鲁直 added 2 commits July 5, 2023 15:43
Using apache common-langs StringUtils instead of sofa-common-util's StringUtil under profile package, sofa-common-utils's StringUtil under profile package is removed from newer sofa-common-util version.
@khotyn khotyn requested a review from huanglongchao July 6, 2023 05:46
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #332 (7bc30c7) into master (c9cbee4) will increase coverage by 0.19%.
The diff coverage is 84.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #332      +/-   ##
============================================
+ Coverage     76.40%   76.59%   +0.19%     
  Complexity       48       48              
============================================
  Files           493      495       +2     
  Lines         18249    18488     +239     
  Branches       1783     1802      +19     
============================================
+ Hits          13943    14161     +218     
- Misses         3502     3517      +15     
- Partials        804      810       +6     
Impacted Files Coverage Δ
.../registry/server/session/push/FirePushService.java 57.26% <0.00%> (-0.26%) ⬇️
...stry/server/shared/util/PersistenceDataParser.java 22.22% <0.00%> (ø)
...istry/store/api/elector/AbstractLeaderElector.java 85.29% <ø> (ø)
...try/jdbc/convertor/AppRevisionDomainConvertor.java 67.64% <0.00%> (ø)
...ofa/registry/server/session/push/RegProcessor.java 82.88% <30.76%> (-7.12%) ⬇️
...fa/registry/server/session/push/PushProcessor.java 78.03% <69.23%> (-0.74%) ⬇️
...a/registry/server/session/push/PushTaskBuffer.java 76.85% <78.57%> (+<0.01%) ⬆️
.../registry/server/session/push/ChangeProcessor.java 90.38% <85.71%> (-0.83%) ⬇️
.../providedata/FetchPushEfficiencyConfigService.java 87.50% <87.50%> (ø)
...rver/session/push/PushEfficiencyImproveConfig.java 90.00% <90.00%> (ø)
... and 6 more

... and 48 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb984a8...7bc30c7. Read the comment docs.

@khotyn khotyn changed the title Remove sofa common util stringtutil usage Remove sofa common util stringutil usage Jul 6, 2023
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 79ffc04 into master Jul 8, 2023
@nobodyiam nobodyiam deleted the remove_sofa_common_util_stringtutil_usage branch July 8, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants