Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add case sensitive feature and unpub/unsub event #87

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

straybirdzls
Copy link
Member

@straybirdzls straybirdzls commented Feb 14, 2020

Motivation:

  • add case sensitive feature
  • add unpub/unsub event

@straybirdzls straybirdzls added this to the 5.4.0 milestone Feb 14, 2020
@straybirdzls straybirdzls self-assigned this Feb 14, 2020
Copy link
Contributor

@atellwu atellwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #87 into master will increase coverage by 0.14%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #87      +/-   ##
===========================================
+ Coverage     62.35%   62.5%   +0.14%     
  Complexity       44      44              
===========================================
  Files           429     429              
  Lines         15439   15446       +7     
  Branches       1487    1488       +1     
===========================================
+ Hits           9627    9654      +27     
+ Misses         4789    4771      -18     
+ Partials       1023    1021       -2
Impacted Files Coverage Δ Complexity Δ
.../alipay/sofa/registry/task/listener/TaskEvent.java 90.9% <100%> (+0.28%) 0 <0> (ø) ⬇️
...pay/sofa/registry/common/model/store/DataInfo.java 45.94% <33.33%> (-2.63%) 0 <0> (ø)
...egistry/common/model/constants/ValueConstants.java 70% <77.77%> (+12.85%) 0 <0> (ø) ⬇️
...ting/sessionserver/disconnect/DisconnectEvent.java 58.33% <0%> (-8.34%) 0% <0%> (ø)
...ver/session/bootstrap/SessionServerConfigBean.java 51.65% <0%> (+0.7%) 0% <0%> (ø) ⬇️
...y/sofa/registry/task/batcher/AcceptorExecutor.java 72.72% <0%> (+0.82%) 0% <0%> (ø) ⬇️
...alipay/sofa/registry/remoting/bolt/BoltClient.java 56% <0%> (+2%) 0% <0%> (ø) ⬇️
...rver/session/node/service/DataNodeServiceImpl.java 67.03% <0%> (+6.7%) 0% <0%> (ø) ⬇️
...try/server/session/remoting/DataNodeExchanger.java 67.3% <0%> (+7.69%) 0% <0%> (ø) ⬇️
...y/sofa/registry/server/data/change/ChangeData.java 75% <0%> (+8.33%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c503394...4f6af1a. Read the comment docs.

@Synex-wh Synex-wh merged commit c95c518 into sofastack:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants