upgrade fury to apache fury #1434
Conversation
sofastack-cla
bot
added
cla:yes
WalkthroughThe recent changes focus on upgrading the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant FuryLibrary as Fury
Client->>Fury: Request Serialization
Fury-->>Client: Return Serialized Data
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- all/pom.xml (2 hunks)
- bom/pom.xml (2 hunks)
- codec/codec-sofa-fury/pom.xml (1 hunks)
- codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java (1 hunks)
- codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/serialize/SofaRequestFurySerializer.java (1 hunks)
- codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/serialize/SofaResponseFurySerializer.java (1 hunks)
Files skipped from review due to trivial changes (2)
- codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/serialize/SofaRequestFurySerializer.java
- codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/serialize/SofaResponseFurySerializer.java
Additional comments not posted (6)
codec/codec-sofa-fury/pom.xml (1)
31-31: Dependency Group ID UpdatedThe group ID for the
fury-coredependency has been updated toorg.apache.fury, aligning with the Apache version of the library. Ensure that this change is compatible with the rest of the project dependencies.codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java (1)
33-38: Import Statements UpdatedThe import statements have been updated to reflect the new package structure under
org.apache.fury. This change is necessary for compatibility with the Apache version of the Fury library. Ensure that all usages of these imports are compatible with the new library version.Also applies to: 44-44
bom/pom.xml (2)
42-42: Fury Library Version UpdatedThe version of the Fury library has been upgraded from
0.4.1to0.6.0. This update may include new features, improvements, or bug fixes. Ensure compatibility with the rest of the project.
306-306: Dependency Group ID UpdatedThe group ID for the
fury-coredependency has been updated toorg.apache.fury, aligning with the Apache version of the library. Ensure that this change is compatible with the rest of the project dependencies.all/pom.xml (2)
445-445: Verify the correct usage of the new group IDorg.apache.fury.The
groupIdforfury-corehas been changed fromorg.furyiotoorg.apache.fury. Ensure this new group ID is correctly referenced throughout the project.Verification successful
The new group ID
org.apache.furyis correctly used throughout the project.The old group ID
org.furyiois not found, indicating a successful transition to the new group ID. The relevantpom.xmlfiles reflect this change consistently.
codec/codec-sofa-fury/pom.xmlall/pom.xmlbom/pom.xmlScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct usage of the new group ID `org.apache.fury`. # Test: Search for references to the old and new group IDs to ensure consistency. rg --type xml 'org\.furyio|org\.apache\.fury' -A 3Length of output: 733
76-76: Verify compatibility with Fury version 0.6.0.The
fury.versionhas been upgraded from0.4.1to0.6.0. Ensure that this version is compatible with your project and does not introduce breaking changes.
|
@chuailiwu PTAL |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- all/pom.xml (2 hunks)
- bom/pom.xml (2 hunks)
- codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java (1 hunks)
Files skipped from review due to trivial changes (1)
- codec/codec-sofa-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java
Additional comments not posted (4)
bom/pom.xml (2)
42-42: Upgrade to Apache Fury version 0.7.0.The version upgrade from
0.4.1to0.7.0indicates potential new features or improvements. Ensure compatibility with the rest of the codebase.
306-306: Update group ID toorg.apache.fury.The group ID change from
org.furyiotoorg.apache.furyreflects a rebranding or organizational change. Verify that all relevant references in the codebase are updated accordingly.all/pom.xml (2)
76-76: Upgrade to Apache Fury version 0.7.0.The version upgrade from
0.4.1to0.7.0indicates potential new features or improvements. Ensure compatibility with the rest of the codebase.
445-445: Update group ID toorg.apache.fury.The group ID change from
org.furyiotoorg.apache.furyreflects a rebranding or organizational change. Verify that all relevant references in the codebase are updated accordingly.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
org.apache.fury, ensuring continued functionality.