Compile time definition of config-defaults.toml for binary and sample #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flamion
reviewed
Oct 14, 2023
| max_json_size_default = 2_097_152 # 2 mebibyte | ||
| max_custom_id_length_default = 500 | ||
| max_uses_default = 0 # unlimited uses | ||
| valid_for_duration_default = 604800000 # 7 days |
There was a problem hiding this comment.
It'd be better if the file ended with a newline
flamion
approved these changes
Oct 14, 2023
zUnixorn
pushed a commit
that referenced
this pull request
Oct 15, 2023
* Remove unused binding in endpoint macro * Simplify get local offset function in util.rs * Define defaults used in the printed sample config in config-defaults.toml * Fix bug where string values from the configuration are passed with quotes * Revert "Revert "Compile time definition of config defaults in separate toml file (#73)"" This reverts commit a057e06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71