Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scipy #359

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Remove scipy #359

merged 3 commits into from
Jun 17, 2020

Conversation

nkeim
Copy link
Contributor

@nkeim nkeim commented Jun 15, 2020

This addresses #355 by removing the fallback of ImageSequence to scipy.misc.imread(), which was deprecated and is now removed. Since this was the only use of scipy in PIMS, this is (nearly) equivalent to removing all references to scipy in the package.

@nkeim nkeim added this to the v0.5 milestone Jun 15, 2020
Copy link
Member

@caspervdw caspervdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this issue @nkeim

conda-recipe/meta.yaml Outdated Show resolved Hide resolved
This is now handled entirely by conda-forge.
@nkeim
Copy link
Contributor Author

nkeim commented Jun 16, 2020

This should now be ready to merge! I added mention of this PR to the v0.5 release notes in #345 .

@tacaswell tacaswell merged commit 731203c into soft-matter:master Jun 17, 2020
nkeim added a commit to regro-cf-autotick-bot/pims-feedstock that referenced this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants