FIX #738 #742
Merged
FIX #738 #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkeim
approved these changes
Nov 22, 2023
|
Thanks for this contribution, @vivarose !! I agree that the fix proposed by @rodrigo-j-goncalves should work. However, since then there have been even more pandas changes that prevent our tests from passing. (This is mostly a result of my being unable to contribute for a few months.) So I'm going to hold off on merging while I try to address those. |
|
Almost all the new errors should be fixed shortly by #743, so I'm comfortable merging now. Thanks again!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the fix that rodrigo-j-goncalves commented on June 23