Make examples and generated code work with rust_2018_idioms lint. #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Nov 3, 2022
lrlex/src/lib/ctbuilder.rs
Outdated
| @@ -68,6 +68,15 @@ impl Visibility { | |||
| } | |||
| } | |||
|
|
|||
| /// Specifies the [^Rust Edition] that will be emitted during code generation. | |||
There was a problem hiding this comment.
It was part of the footnote syntax of cargo doc, but looking at the generated doc (oops),
it looked terrible with the footnote style. I managed to get it working so the link text shows up inline.
while not making line-length terrible asymmetric.
Should be fixed in bb1e970
There was a problem hiding this comment.
There are still a couple of other [^s in the PR -- should they disappear too?
There was a problem hiding this comment.
Sorry still 😴 ☕, they probably should.
There was a problem hiding this comment.
Fixed the one in lrlex now in 931202f
ltratt
reviewed
Nov 3, 2022
|
Please squash. |
ratmice
force-pushed
the
rust_2018_idioms
branch
from
931202f
to
b641255
Compare
|
Squashed. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to my previous pull request #365, towards the end of writing this patch
my understanding of
rust_2018_idiomschanged, e.g. for some reason I thought it was a 2018 -> 2021 thing,but it's actually a 2015 -> 2018 change. It lints against code which was previously accepted by 2015 compilers,
was deprecated in the 2018 edition.
But the lints which deprecated have never been completed to the satisfaction of being enabled by default.
tracking issue: rust-lang/rust#54910
As such i'm really not sure about the conditional code generation being necessary for this.
the new code generated for > 2015 was accepted by 2015 edition, and expect the old code to have lints enabled for them
in the future.
But perhaps this edition stuff would be useful to have everything in place for future edition changes?
As such I figure i'll just make the PR with what I have, and we can trim it down if we want...