Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved pipe building logic #18

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Conversation

robot256
Copy link
Collaborator

@robot256 robot256 commented Nov 22, 2021

  • Fixed pipes not building correctly toward narrow rectangular neighbors, by detecting adjacent edges.
  • Fixed pipes being built in a grid if connector is offset from miner center line. Will now build an L-shape if the miner's connector is offset in both X and Y.
  • Added more debug messages about pipes.

There is still a potential problem for miners with an even width.

Make fluid direction finding code more compact and readable.
* Fixed pipes not building correctly to rectangular neighbors by detecting adjacent edges.
* Fixed pipes being build in a grid if connector is offset.  Will now build an L-shape if the miner's connector is offset in both X and Y.
* Added more debug messages about pipes.
@robot256 robot256 changed the title Fix #17, improved pipe building logic Improved pipe building logic Nov 22, 2021
@softmix softmix merged commit 3303a9b into softmix:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants