Methods to get latest release and release by tag name #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softprops
reviewed
Aug 18, 2018
src/releases/mod.rs
Outdated
| /// | ||
| /// See the [github docs](https://developer.github.com/v3/repos/releases/#get-the-latest-release) | ||
| /// for more information. | ||
| pub fn get_latest(&self) -> Future<Release> { |
There was a problem hiding this comment.
I don't have super strong opinions about this but for rustyness sake there are some suggestions in the rust style guide that suggest avoiding get_ prefixes
If you don't feel strongly about holding onto this name, what do you think about just latest and something like by_tag for_tag or with_tag below?
There was a problem hiding this comment.
i actually thought about these variants for a moment after i opened the PR
More doc comments & releases example
|
Thanks I'm going to include these changes in this weekend's release |
|
these changes are now published in 0.4.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #51 and adds more doc comments and a
releasesexample