Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contents interface #155

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

jasonwhite
Copy link
Collaborator

@jasonwhite jasonwhite commented Sep 21, 2018

A new version hasn't been published with the last PR that added support to the contents API (#150), so this breaking change should be acceptable:

  • Handles paths with spaces and other special characters.
  • Handles decoding the file contents upon deserialization.
  • Handles the case where we don't know what type of item will be returned using an enum variant. (Is it a file, symlink, or a submodule?)
  • Returns a stream of directory items instead of a Future<Vec<DirectoryItem>>. We can use .collect() if the latter is needed.

Handles URLs with spaces and other special characters.

Handles decoding the file contents upon deserialization.

Handles the case where we don't know what type of item will be returned.
(Is it a file, symlink, or a submodule?)

Returns a stream of directory items.
Copy link
Owner

@softprops softprops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. I'm try to roll these recent changes into a new release soon

@softprops softprops merged commit 76f10c1 into softprops:master Sep 22, 2018
@jasonwhite jasonwhite deleted the jason/decoded-content branch September 22, 2018 17:45
@jasonwhite jasonwhite restored the jason/decoded-content branch April 12, 2019 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants