Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port hyperlocal client to latest hyper #29

Merged
merged 13 commits into from
Jan 10, 2020

Conversation

danieleades
Copy link
Contributor

This was required to support porting shiplift to futures 0.3 (softprops/shiplift#191).

I've disabled the server implementation for now, and have ported only the client.

@softprops
Copy link
Owner

@danieleades I just merged #25 let me know if that unblocks what you were blocked on for this pull

@danieleades danieleades marked this pull request as ready for review December 1, 2019 22:46
@danieleades
Copy link
Contributor Author

danieleades commented Dec 1, 2019

tokio has just released a stable release using futures::Stream, instead of futures-preview::Stream. I would expect Hyper to bump it's dependency any day now. Once that happens, this pull request should be updated, or if it is merged, a new pull request should be opened for that update.

only then will i be unblocked downstream (otherwise we have a mixture of futures-preview::Stream and futures::Stream in the dependencies, and they don't play nicely together).

@danieleades
Copy link
Contributor Author

danieleades commented Dec 2, 2019

i'm happy this is ready to merge. it's a major change, and a big refactor of the client and uri modules.

@danieleades
Copy link
Contributor Author

For visibility, hyper has just merged the move to futures, rather than futures-preview. Once this is released, hyperlocal should bump the hyper dependency and move to stable tokio

@danieleades
Copy link
Contributor Author

hyper has just released. will update this pull request in the next couple of days.

@danieleades
Copy link
Contributor Author

this is now updated to latest hyper.

@danieleades
Copy link
Contributor Author

closes #23

@danieleades
Copy link
Contributor Author

closes #22

@danieleades
Copy link
Contributor Author

ping @softprops

@softprops
Copy link
Owner

Sorry for the many delays on this. @danieleades I'll try to commit to going though this but the end of the weekend.

@softprops
Copy link
Owner

This looks great! I'm shoot for a release this weekend

@softprops softprops merged commit 53b2a13 into softprops:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants