feat: add the capability to override the docker cli and arguments #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In environments that don't provide the `docker` command, or in which it is on a different path, the variable `SLS_DOCKER_CLI` can be used to override the default, and the `SLS_DOCKER_ARGS` can be used to set additional parameters for the `run` subcommand as needed. For example, in environments which provide `podman` instead: ``` $ SLS_DOCKER_CLI=podman serverless invoke ... ```
|
@softprops let me know what you think of this and if I should add this to the changelog |
|
Looks good @sebasmagri |
|
@softprops any chance to get this released? |
|
Sorry for the lag on this. I'll try to get to that at lastest by next weekend. I'll update this thread when I do |
|
Hey @softprops! Any way I can help getting this thru? Best Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In environments that don't provide the
dockercommand, or in which it is on a different path, the variableSLS_DOCKER_CLIcan be used to override the default, and theSLS_DOCKER_ARGScan be used to set additional parameters for therunsubcommand as needed.For example, in environments which provide
podmaninstead: