Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling, make import to typescript possible #20

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

konsultaner
Copy link
Contributor

@konsultaner konsultaner commented Dec 17, 2018

I tried to fix #7. It does fix it but has some tslint errors.

If you import with import SecureLS from 'secure-ls'; it autocompletes correct in WebStorm and loads the resources, but shows tslint errors.

I also fixed the spelling of a method and added .idea to .gitignore

All up its a start but not perfect.

@coveralls
Copy link

coveralls commented Dec 17, 2018

Coverage Status

Coverage remained the same at 85.932% when pulling 05a931e on konsultaner:master into 93e1152 on softvar:master.

@softvar
Copy link
Owner

softvar commented Dec 17, 2018

Nice work @konsultaner 👍
Are there still any linting errors? Or the PR is good to be merged?

@konsultaner
Copy link
Contributor Author

konsultaner commented Dec 17, 2018

Are there still any linting errors?

Only in the d.ts file in your project. The importing project has no linting errors if imported like this:

import SecureLS from 'secure-ls'

it is probably optimizable, but mergable im my eyes.

@softvar softvar merged commit 614534b into softvar:master Dec 18, 2018
@softvar
Copy link
Owner

softvar commented Dec 18, 2018

@konsultaner Thanks for the wonderful work

@jstncno jstncno mentioned this pull request Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typings support for Typescript
3 participants