Fixed #15 and #22 #24
Conversation
|
@softvar since this is a breaking change you might want to update the version to 1.3.0 |
@jas- I completely removed the default password
|
| @@ -17,12 +15,6 @@ let utils = { | |||
| reason = reason ? reason : constants.WarningEnum.DEFAULT_TEXT; | |||
| console.warn(constants.WarningTypes[reason]); | |||
| }, | |||
| generateSecretKey: function () { | |||
There was a problem hiding this comment.
Could you please explain why are these lines removed?
There was a problem hiding this comment.
Due to the issues a predefined password does not work with common security standards. You saved the password in the local storege. This was not secure. Thats why I removed it. The user should use a trusted endpoint to deliver the password. In the most cases this would be the logged in user or a trusted third party.
| if (!this._isBase64 && typeof this.config.encryptionNamespace === 'undefined') { | ||
| this.utils.warn(this.WarningEnum.ENCRYPTION_NAMESPACE_NOT_PROVIDED); | ||
| } | ||
| if ( |
There was a problem hiding this comment.
some inline comments would help understanding the code
|
@konsultaner Could you please help in maintaining the coverage as well by adding test cases for the new code? |
@softvar I mostly removed code. I added tests for the code I added. This was mainly the console warnings for If you find untested code I added let me know. I'll provide test for it then. |
|
@softvar I also changed some tests for the metaKey |
|
@softvar is there anything needed for you to accept the PR? |
softvar
force-pushed
the
master
branch
6 times, most recently
from
13b758b
to
e32ce42
Compare
@softvar I forgot to pull your changes before. You might need to update the builds again. I did not update the version, because you might want to fix things first before you release.