Add window or global to allow SSR compatibility

[moogus]

Add window or global to allow SSR compatibility

This work aims to allow the use of this module in a server side rendered environment. This work does not enable the module for use on the server but removes window dependancies.

• add window-or-global package
• update localStorage with global fallback

[softvar]

Can we please also set the storage type on window?

this.ls = root[root.storageType || 'localStorage'] || globalStorage;

[moogus]

root in this context is the window, the aim was to stop the library breaking when used in ssr enabled applications.

I'm not aware of storageType as a window property

[moogus]

I think I may not provided enough context to the PR, sorry. I've had an issue with SSR in react this is my current work around when using SecureLS:

const getSecureLS = () => {
  if (typeof window !== 'undefined') {
    return new SecureLS({});
  }
  return {
    set: () => ({}),
    get: () => ({}),
    remove: () => ({}),
  };
};

[softvar]

Shouldn't it be:

const globalStorage = root.customStorage || {setItem: () => {},
  getItem: () => {},
  removeItem: () => {},
  clear: () => {}
};

this will allow overriding the global object and defining your own. Thoughts?

[moogus]

What would customStorage be?

Are you assuming this would be on the global object when used in a node environment? If so maybe it could be set as a property for use in server node apps. I'm not sure this library would be used on the server.

[softvar]

This would help in defining custom methods(get, set, etc.) when localStorage is not present(in case of incognito mode and cookies disabled scenario). It will help there.

[moogus]

localStorage is available in incognito. I'm not quite sure what scenario you are suggesting can you specify a browser etc.

[moogus]

@softvar any final thoughts?

[NayamAmarshe]

Any updates on this?