Skip to content

Commit

Permalink
suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
piotmag769 committed Mar 1, 2024
1 parent 311accd commit 8641b83
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions crates/profiler/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std::{
io::{Read, Write},
};

use crate::trace_reader::{collect_resources_keys, collect_samples_from_trace};
use crate::trace_reader::{collect_resources_units, collect_samples_from_trace};
use anyhow::{Context, Result};
use bytes::{Buf, BytesMut};
use camino::Utf8PathBuf;
Expand Down Expand Up @@ -36,7 +36,7 @@ fn main() -> Result<()> {
let serialized_trace: CallTrace =
serde_json::from_str(&data).context("Failed to deserialize call trace")?;
let samples = collect_samples_from_trace(&serialized_trace);
let resources_keys = collect_resources_keys(&samples);
let resources_keys = collect_resources_units(&samples);

let profile = build_profile(&samples, &resources_keys);

Expand Down
10 changes: 5 additions & 5 deletions crates/profiler/src/trace_reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,26 +143,26 @@ impl ResourcesUnits {
}
}

pub fn collect_resources_keys(samples: &[Sample]) -> ResourcesUnits {
let mut keys = HashSet::new();
pub fn collect_resources_units(samples: &[Sample]) -> ResourcesUnits {
let mut units = HashSet::new();
for sample in samples {
keys.extend(
units.extend(
sample
.flat_resources
.vm_resources
.builtin_instance_counter
.keys()
.cloned(),
);
keys.extend(
units.extend(
sample
.flat_resources
.syscall_counter
.keys()
.map(|x| format!("{x:?}")),
);
}
ResourcesUnits(keys)
ResourcesUnits(units)
}

fn collect_samples<'a>(
Expand Down

0 comments on commit 8641b83

Please sign in to comment.