Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on onDrawerStateChanged of Drawer Layout need to explain its second argument, drawerWillShow: boolean. #2993

Closed
sinibida opened this issue Jul 15, 2024 · 4 comments · Fixed by #3000
Closed

Documentation on onDrawerStateChanged of Drawer Layout need to explain its second argument, drawerWillShow: boolean. #2993

sinibida opened this issue Jul 15, 2024 · 4 comments · Fixed by #3000
Labels
Missing info Missing repro Platform: Android This issue is specific to Android

Comments

@sinibida
Copy link

sinibida commented Jul 15, 2024 •
edited
Loading

Description

The argument drawerWillShow of onDrawerStateChanged of DrawerLayout should be documented, as this is the only reliable way of telling whether the settling drawer is closing, or opening. (a.k.a if the drawer has started opening or closing) The current documentation website lacks of this explanation. #

Related Discussion: #1866

Steps to reproduce

.

Snack or a link to a repository

.

Gesture Handler version

.

React Native version

.

Platforms

Android

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Steps to reproduce, Snack or a link to a repository, Gesture Handler version and React Native version sections.

@github-actions github-actions bot added the Platform: Android This issue is specific to Android label Jul 15, 2024
@github-actions GitHub Actions
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@m-bert
Copy link
Contributor

m-bert commented Jul 16, 2024

Hi @sinibida! I've just added that in #3000. Could you please check that and tell me if there is something more that you think that should be added?

@sinibida
Copy link
Author

Nope, looks great! Thank you for your service.

@m-bert m-bert closed this as completed Jul 17, 2024
@m-bert m-bert mentioned this issue Jul 17, 2024
Merged
m-bert added a commit that referenced this issue Jul 17, 2024
@m-bert
Mention drawerWillShow in DrawerLayout docs (#3000)
5a671e9 
## Description

This PR adds detailed description for `onDrawerStateChanged` in our
documentation.

Closes #2993 

## Test plan

Run docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Missing info Missing repro Platform: Android This issue is specific to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention drawerWillShow in DrawerLayout docs software-mansion/react-native-gesture-handler
2 participants
@sinibida @m-bert