-
-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set library namespace in build script #2435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
hyochan
referenced
this pull request
in hyochan/dooboo-ui
Jun 10, 2023
…400) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-gesture-handler](https://github.com/software-mansion/react-native-gesture-handler) | [`~2.9.0` -> `~2.11.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.9.0/2.11.0) | [![age](https://badges.renovateapi.com/packages/npm/react-native-gesture-handler/2.11.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/react-native-gesture-handler/2.11.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/react-native-gesture-handler/2.11.0/compatibility-slim/2.9.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/react-native-gesture-handler/2.11.0/confidence-slim/2.9.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-gesture-handler</summary> ### [`v2.11.0`](https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.11.0) [Compare Source](https://github.com/software-mansion/react-native-gesture-handler/compare/2.10.2...2.11.0) A small release made for nice people at Expo 😃. #### 🐛 Bug fixes - Correctly attach root view recognizer in modals on iOS by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2498](https://github.com/software-mansion/react-native-gesture-handler/pull/2498) **Full Changelog**: software-mansion/react-native-gesture-handler@2.10.2...2.11.0 ### [`v2.10.2`](https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.10.2) [Compare Source](https://github.com/software-mansion/react-native-gesture-handler/compare/2.10.1...2.10.2) #### 🐛 Bug fixes - Fix root view error for jest by [@​IvanIhnatsiuk](https://github.com/IvanIhnatsiuk) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2491](https://github.com/software-mansion/react-native-gesture-handler/pull/2491) - Prevent GH buttons from activating when scrolling list by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2494](https://github.com/software-mansion/react-native-gesture-handler/pull/2494) #### New Contributors - [@​IvanIhnatsiuk](https://github.com/IvanIhnatsiuk) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2491](https://github.com/software-mansion/react-native-gesture-handler/pull/2491) **Full Changelog**: software-mansion/react-native-gesture-handler@2.10.1...2.10.2 ### [`v2.10.1`](https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.10.1) [Compare Source](https://github.com/software-mansion/react-native-gesture-handler/compare/2.10.0...2.10.1) #### 🐛 Bug fixes - Fix operation scheduling on iOS by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2483](https://github.com/software-mansion/react-native-gesture-handler/pull/2483) ### [`v2.10.0`](https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.10.0) [Compare Source](https://github.com/software-mansion/react-native-gesture-handler/compare/2.9.0...2.10.0) #### ❗ Important changes - Enable the new web implementation by default by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2394](https://github.com/software-mansion/react-native-gesture-handler/pull/2394) - Replace `setImmediate` and `requestAnimationFrame` with `queueMicrotask` by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2467](https://github.com/software-mansion/react-native-gesture-handler/pull/2467) - Show error when gestures are used without root view by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2420](https://github.com/software-mansion/react-native-gesture-handler/pull/2420) - Change how velocity is calculated on the new web implementation by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2443](https://github.com/software-mansion/react-native-gesture-handler/pull/2443) #### 🐛 Bug fixes - Fix types for gestureHandlerRootHOC to accept component with props by [@​Nodonisko](https://github.com/Nodonisko) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2413](https://github.com/software-mansion/react-native-gesture-handler/pull/2413) - Remove `DrawerLayoutAndroid` import on web by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2305](https://github.com/software-mansion/react-native-gesture-handler/pull/2305) - Fix ripple always showing on Touchables when on Android 13 by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2418](https://github.com/software-mansion/react-native-gesture-handler/pull/2418) - Whitelist `Native` gesture props in `GestureDetector` by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2433](https://github.com/software-mansion/react-native-gesture-handler/pull/2433) - Fix Gesture Handlers getting stuck due to missing `up` event when using the new web implementation by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2442](https://github.com/software-mansion/react-native-gesture-handler/pull/2442) - Fix Gesture Handler's buttons activating after scroll when using `RefreshControl` by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2457](https://github.com/software-mansion/react-native-gesture-handler/pull/2457) - Make single instance assertion work with Gradle Configuration Cache by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2453](https://github.com/software-mansion/react-native-gesture-handler/pull/2453) - fix: PureNativeButton is not exported by [@​magrinj](https://github.com/magrinj) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2447](https://github.com/software-mansion/react-native-gesture-handler/pull/2447) - fix: do not apply namespace if it is not available in agp by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2448](https://github.com/software-mansion/react-native-gesture-handler/pull/2448) #### 👍 Improvements - Returns Swipeable reference on renderLeftActions by [@​ntocampos](https://github.com/ntocampos) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2426](https://github.com/software-mansion/react-native-gesture-handler/pull/2426) - Add a method `reset` to component `Swipeable` by [@​UNIDY2002](https://github.com/UNIDY2002) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2431](https://github.com/software-mansion/react-native-gesture-handler/pull/2431) - Remove conditional imports for native components by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2461](https://github.com/software-mansion/react-native-gesture-handler/pull/2461) - Add `dragOffsetFromLeftEdge` and `dragOffsetFromRightEdge` props to `Swipeable` by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2408](https://github.com/software-mansion/react-native-gesture-handler/pull/2408) #### 🔢 Miscellaneous - Bump ua-parser-js from 0.7.31 to 0.7.33 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2392](https://github.com/software-mansion/react-native-gesture-handler/pull/2392) - Bump ua-parser-js from 0.7.24 to 0.7.33 in /docs by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2389](https://github.com/software-mansion/react-native-gesture-handler/pull/2389) - Hide `back-to-top` button in the docs by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2398](https://github.com/software-mansion/react-native-gesture-handler/pull/2398) - Upgrade Expo in the example app to use API 47 by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2393](https://github.com/software-mansion/react-native-gesture-handler/pull/2393) - chore: change fabric flag by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2397](https://github.com/software-mansion/react-native-gesture-handler/pull/2397) - Bump http-cache-semantics from 4.1.0 to 4.1.1 in /docs by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2407](https://github.com/software-mansion/react-native-gesture-handler/pull/2407) - Bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2406](https://github.com/software-mansion/react-native-gesture-handler/pull/2406) - End-to-end tests for web version by [@​m-bert](https://github.com/m-bert) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2298](https://github.com/software-mansion/react-native-gesture-handler/pull/2298) - Bump ua-parser-js from 0.7.32 to 0.7.33 in /e2e/web-tests by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2417](https://github.com/software-mansion/react-native-gesture-handler/pull/2417) - Bump loader-utils from 1.4.0 to 1.4.2 in /e2e/web-tests by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2416](https://github.com/software-mansion/react-native-gesture-handler/pull/2416) - Bump decode-uri-component from 0.2.0 to 0.2.2 in /e2e/web-tests by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2415](https://github.com/software-mansion/react-native-gesture-handler/pull/2415) - Add `Handler state` section to sidebar by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2422](https://github.com/software-mansion/react-native-gesture-handler/pull/2422) - Bump webpack from 5.73.0 to 5.76.1 in /docs by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2436](https://github.com/software-mansion/react-native-gesture-handler/pull/2436) - chore: set library namespace in build script by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2435](https://github.com/software-mansion/react-native-gesture-handler/pull/2435) - docs: add appjs banner by [@​kacperkapusciak](https://github.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2432](https://github.com/software-mansion/react-native-gesture-handler/pull/2432) - Bump [@​xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6 to 0.7.9 in /e2e/web-tests by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2444](https://github.com/software-mansion/react-native-gesture-handler/pull/2444) - Bump [@​sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1 in /e2e/web-tests by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2445](https://github.com/software-mansion/react-native-gesture-handler/pull/2445) - Bump minimist from 1.2.5 to 1.2.8 in /example by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2456](https://github.com/software-mansion/react-native-gesture-handler/pull/2456) - Move `GestureHandlerRootView` to `components` directory by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2468](https://github.com/software-mansion/react-native-gesture-handler/pull/2468) - Remove unnecessary `throw` by [@​j-piasecki](https://github.com/j-piasecki) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2446](https://github.com/software-mansion/react-native-gesture-handler/pull/2446) #### New Contributors - [@​Nodonisko](https://github.com/Nodonisko) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2413](https://github.com/software-mansion/react-native-gesture-handler/pull/2413) - [@​ntocampos](https://github.com/ntocampos) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2426](https://github.com/software-mansion/react-native-gesture-handler/pull/2426) - [@​UNIDY2002](https://github.com/UNIDY2002) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2431](https://github.com/software-mansion/react-native-gesture-handler/pull/2431) - [@​magrinj](https://github.com/magrinj) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2447](https://github.com/software-mansion/react-native-gesture-handler/pull/2447) **Full Changelog**: software-mansion/react-native-gesture-handler@2.9.0...2.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since AGP 8.0 project namespace must be set inside build script.
It is also the recommended way in Android docs.
It is also recommended, that the package name definition is removed from Android manifest file, but I've had some problems in
react-native-screens
with RN CLI crashing (as it was expecting thepackage
field to exist) & according to this conversation it'll still be legal to leave package name definition in Android manifest file as long as it exactly matches the value in build script.See: software-mansion/react-native-screens#1717
Test plan