feat: try to enable bridgeless mode in the library #2708
Conversation
| @@ -5,6 +5,8 @@ import { | |||
| DeviceEventEmitter, | |||
| EmitterSubscription, | |||
| } from 'react-native'; | |||
| // @ts-ignore - its taken straight from RN | |||
| import { customDirectEventTypes } from 'react-native/Libraries/Renderer/shims/ReactNativeViewConfigRegistry'; | |||
There was a problem hiding this comment.
Sorry for butting into your PR. From your talks with the Meta team, did they say this is the way to do it and there is no other way? I am facing a similar issue trying to send Fabric events in bridgeless mode. This looks very brittle. What happens to older versions where this doesn't exist? Or if they ever decide to change this import?
There was a problem hiding this comment.
Nope, I have as much information as you 😅 This was available on e.g. v0.67: https://github.com/facebook/react-native/blob/v0.67.0/Libraries/Renderer/shims/ReactNativeViewConfigRegistry.js and it is very old version already. And hopefully they won't change the import or maybe they'll fix this so we don't need to use it anymore.
There was a problem hiding this comment.
Ouch 😅. Alright, I'll probably be a bit more careful then 😂. Fingers crossed
|
Closing since #2766 has been merged. |
Description
PR adding code necessary for the bridgeless mode to be supported in the library. For now it's rather a PoC of what needs to be done for it.
Test plan