Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs page for Reanimated Swipeable #2962
Add docs page for Reanimated Swipeable #2962
Changes from all commits
0478eb6
7ce9b53
f7dabef
f16b01e
da42684
73e1928
526e079
fdcede8
b829852
673e037
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the
[0, +]
,[0, -]
notationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means these values travel from
0
topositive infinity
and from0
tonegative infinity
respectively.I copied this notation from the legacy
Swipeable
docs for consistency, but i can write it down differently if you'd prefer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[0, +]
is not that bad, but[0, -]
is confusingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
[0, +∞]
and[0, -∞]
fine?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant is not the infinity sign, but rather the notation of
[0, -∞]
(it doesn't follow formal definition of interval). I'm not sure though if that is what @kacperkapusciak meant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey so what's the verdict on this issue?
As far as I see, the formal way would be to note it this way:
(-∞, 0]
and[0, +∞)
But since here, it represents a mapping from
input
tooutput
, i think[0, -∞)
and[0, +∞)
would be more readable.Please let me know, which one you think would work better @m-bert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't like
[0, -∞)
because it looks very unnatural to me. On the other hand I cannot think of any better idea 😞 One could argue that if we only talk about input and output range, we could leave formal notation (but it is not a strong argument)Anyway, it was @kacperkapusciak who has started this discussion and I want to know what's his stance on this