Responding to comments

software-mansion · Dec 13, 2022 · b346425 · b346425
1 parent 71257e3
commit b346425
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/Common/cpp/ReanimatedRuntime/ReanimatedHermesRuntime.cpp b/Common/cpp/ReanimatedRuntime/ReanimatedHermesRuntime.cpp
@@ -80,7 +80,7 @@ ReanimatedHermesRuntime::ReanimatedHermesRuntime(
   jsQueue->quitSynchronous();
 #endif
 
-#ifndef NDEBUG
+#ifdef DEBUG
   jsi::Value evalWithSourceMap = jsi::Function::createFromHostFunction(
       *runtime_,
       jsi::PropNameID::forAscii(*runtime_, "evalWithSourceMap"),
@@ -105,7 +105,7 @@ ReanimatedHermesRuntime::ReanimatedHermesRuntime(
       });
   runtime_->global().setProperty(
       *runtime_, "evalWithSourceMap", evalWithSourceMap);
-#endif
+#endif // DEBUG
 }
 
 ReanimatedHermesRuntime::~ReanimatedHermesRuntime() {

diff --git a/Common/cpp/SharedItems/Shareables.cpp b/Common/cpp/SharedItems/Shareables.cpp
@@ -13,10 +13,10 @@ CoreFunction::CoreFunction(
   rnFunction_ = std::make_unique<jsi::Function>(workletObject.asFunction(rt));
   functionBody_ =
       workletObject.getProperty(rt, "asString").asString(rt).utf8(rt);
-  location_ =
-      "worklet_" +
+  location_ = "worklet_" +
       std::to_string(
-          (int)workletObject.getProperty(rt, "__workletHash").getNumber());
+                  (unsigned int)workletObject.getProperty(rt, "__workletHash")
+                      .getNumber());
 }
 
 std::unique_ptr<jsi::Function> &CoreFunction::getFunction(jsi::Runtime &rt) {

diff --git a/Common/cpp/Tools/RuntimeDecorator.cpp b/Common/cpp/Tools/RuntimeDecorator.cpp
@@ -32,7 +32,7 @@ void RuntimeDecorator::decorateRuntime(
 
   rt.global().setProperty(rt, "global", rt.global());
 
-#ifndef NDEBUG
+#ifdef DEBUG
   auto evalWithSourceUrl = [](jsi::Runtime &rt,
                               const jsi::Value &thisValue,
                               const jsi::Value *args,
@@ -55,7 +55,7 @@ void RuntimeDecorator::decorateRuntime(
           jsi::PropNameID::forAscii(rt, "evalWithSourceUrl"),
           1,
           evalWithSourceUrl));
-#endif
+#endif // DEBUG
 
   auto callback = [](jsi::Runtime &rt,
                      const jsi::Value &thisValue,