Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☔️ Regression in 1.6.0 / 1.5.0 #561

Closed
osdnk opened this issue Jan 16, 2020 · 2 comments
Closed

☔️ Regression in 1.6.0 / 1.5.0 #561

osdnk opened this issue Jan 16, 2020 · 2 comments

Comments

@osdnk
Copy link
Contributor

osdnk commented Jan 16, 2020

I have released a 1.6.0 version yesterday. It was containing a lot of small changes and updates and unfortunately brought few regressions. I want to get rid of them as soon as I can collecting feedback from the community.

Here's a list of issues I'm conscious about:

  1. Start seeing NullPointerException in 1.5.0 #551 fixed by Start seeing NullPointerException in 1.5.0 #551
  2. [Android] NullPointerException - Attempt to invoke virtual method 'void com.swmansion.reanimated.nodes.ValueNode.setValue(java.lang.Object)' on a null object reference #559 fixed by Fix for crashing on Android [#559] #560
  3. Malformed calls from JS: field sizes are different. #557 (comment) fixed by Fallback to old mechanism of setting value if value is a node or string #566
  4. v1.6 Require cycle #558 fixed by Remove cycle of requires in AnimatedParam #562
  5. Assertion failure in -[REANodesManager setValueForNodeID:value:](), #555 fixed by (Remove RCTAssertParam from REANodesManager.m #568)
  6. Exception thrown while executing UI block: -[__NSDictionaryM doubleValue]: unrecognized selector sent to instance 0x600002a99900 #563 fixed by Revert "Fix case where new Animated.Value() is NaN on web" #564

Also, I want to include #556 in order to verify reanimated with a complex example

osdnk added a commit that referenced this issue Jan 16, 2020
Reverts #548

undefined is not casting to null and that's the reason for the #563 regression.

rel: #561
osdnk added a commit that referenced this issue Jan 16, 2020
Fixes #558
rel: #561
Regression made with: #534

In this PR I get rid of the cycle of requires which cause warnings by fixing one of the imports
@Jarred-Sumner
Copy link

Flagging this comment incase it was missed: bdc7b59#commitcomment-36633385

It’s probably too vague to be actionable though

@osdnk
Copy link
Contributor Author

osdnk commented Jan 16, 2020

All issues should be gone

@osdnk osdnk closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants