-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crash: hermes::vm::HadesGC::EvacAcceptor<false>::acceptNullable(hermes::vm::PinnedHermesValue&) ()
#6114
Comments
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
So you can either switch to Paper for the time being, or await next stable release 👍 |
Ah gotcha, I wasn't sure if it was related to Layout Animations or not - thanks for the quick reply! :) |
Dzień dobry @mrousavy, I am a bit confused about this issue since layout animations should be a noop on the new architecture. From your description it seems that some of them were running? |
Yea I do have layout animations, but they are all noop (in my app they just jump to the target value immediately). |
Can you check if removing those layout animations fixes these issues? |
The issue was caused by reanimated accessing the UI runtime from two threads at the same time. Usually this doesn't happen, because we use |
nice investigation! |
Description
Dobry dzień 👋
I just tried upgrading to the new architecture in a hobby project (ShadowLens), and I seem to get a lot of crashes from Reanimated.
Once I stop a recording from the Camera, I play a fade out animation and run an unmount Layout Animation, then a mount Layout Animation for adding the thumbnail to the Gallery, and at some point during this sequence, Reanimated crashes with a Hermes exception:
This one here is interesting to me:
It's exactly the point where we do
obj.setNativeState(...)
:And apparently that crashes!
Worst thing of all is... I wrote that code 😅🤦♂️
I don't know how that can crash to be honest - we are not using
nativeState_
in any of our shareables, are we? Not sure about the new Fabric Shadow Trees if those are already being converted to Shareables tbh.Steps to reproduce
It's hard for me to pinpoint exactly why and how this is happening, so at this point I unfortunately don't have a repro yet.
I'll first try to fix it myself, and then create a repro if I fail to do that.
Snack or a link to a repository
yea again sorry I don't have that yet. see comment above
Reanimated version
^3.12.0
React Native version
0.74.2
Platforms
iOS
JavaScript runtime
Hermes
Workflow
React Native
Architecture
Fabric (New Architecture)
Build type
Release app & production bundle
Device
Real device
Device model
iPhone 15 Pro
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: