Add missing WithRuntimeDecorator methods
#45042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Base commit: db2c44a |
|
@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
neildhar
pushed a commit
to neildhar/react-native
that referenced
this pull request
Jun 18, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. ## Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. Pull Request resolved: facebook#45042 Differential Revision: D58744051 Pulled By: neildhar
neildhar
pushed a commit
to neildhar/react-native
that referenced
this pull request
Jun 24, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. ## Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. Pull Request resolved: facebook#45042 Differential Revision: D58744051 Pulled By: neildhar
neildhar
pushed a commit
to neildhar/react-native
that referenced
this pull request
Jun 25, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. ## Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. Pull Request resolved: facebook#45042 Differential Revision: D58744051 Pulled By: neildhar
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jun 26, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. X-link: facebook/react-native#45042 Reviewed By: fbmal7 Differential Revision: D58744051 Pulled By: neildhar fbshipit-source-id: 3f5c85d0bf7cd6445d0c434ac4ae7ed54df203ba
|
This pull request was successfully merged by @bartlomiejbloniarz in 218ea5d. When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jun 26, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. X-link: facebook/react-native#45042 Reviewed By: fbmal7 Differential Revision: D58744051 Pulled By: neildhar fbshipit-source-id: 3f5c85d0bf7cd6445d0c434ac4ae7ed54df203ba
cortinico
pushed a commit
to facebook/hermes
that referenced
this pull request
Jul 1, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. X-link: facebook/react-native#45042 Reviewed By: fbmal7 Differential Revision: D58744051 Pulled By: neildhar fbshipit-source-id: 3f5c85d0bf7cd6445d0c434ac4ae7ed54df203ba
cortinico
pushed a commit
that referenced
this pull request
Jul 1, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. Pull Request resolved: #45042 Reviewed By: fbmal7 Differential Revision: D58744051 Pulled By: neildhar fbshipit-source-id: 3f5c85d0bf7cd6445d0c434ac4ae7ed54df203ba
This was referenced Aug 15, 2024
This was referenced Sep 19, 2024
Flewp
pushed a commit
to discord/react-native
that referenced
this pull request
Sep 19, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. Pull Request resolved: facebook#45042 Reviewed By: fbmal7 Differential Revision: D58744051 Pulled By: neildhar fbshipit-source-id: 3f5c85d0bf7cd6445d0c434ac4ae7ed54df203ba
janicduplessis
pushed a commit
to janicduplessis/react-native
that referenced
this pull request
Sep 28, 2024
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. Pull Request resolved: facebook#45042 Reviewed By: fbmal7 Differential Revision: D58744051 Pulled By: neildhar fbshipit-source-id: 3f5c85d0bf7cd6445d0c434ac4ae7ed54df203ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds missing
WithRuntimeDecoratormethods related toNativeState. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without thisoverridetheRuntimeDecoratorimplementation was used, bypassing our mutex.Changelog:
[GENERAL] [FIXED] - Add missing
NativeStatemethods to theWithRuntimeDecoratorclass.Test Plan: