Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Reanimated 2 code to TS #1807

Merged
merged 8 commits into from
Mar 24, 2021
Merged

Migrate Reanimated 2 code to TS #1807

merged 8 commits into from
Mar 24, 2021

Conversation

jakub-gonet
Copy link
Member

@jakub-gonet jakub-gonet commented Mar 8, 2021

Description

Rename all files to .ts extension and serve them from the lib/ directory.
This prepares Reanimated v2 to be rewritten in TS.

Test code and steps to reproduce

Tested on example app and manually investigated files in lib/ directory.

Checklist

  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

@jakub-gonet jakub-gonet self-assigned this Mar 12, 2021
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • every file inside src/reanimated2 ends with .ts
  • code works

Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine.

@jakub-gonet jakub-gonet marked this pull request as ready for review March 24, 2021 13:40
@jakub-gonet jakub-gonet changed the title Migrate Rea2 to TS Migrate Reanimated 2 code to TS Mar 24, 2021
@jakub-gonet jakub-gonet merged commit a8d9720 into master Mar 24, 2021
@jakub-gonet jakub-gonet deleted the @kuba/rename-to-ts branch March 24, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants