Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set missing viewRef for animatedProps #1819

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Set missing viewRef for animatedProps #1819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b4c36b
Set missing viewRef for animatedProps
piaskowyk Mar 11, 2021
f11840c
Removed unnecessary nullcheck
piaskowyk Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/createAnimatedComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,9 @@ export default function createAnimatedComponent(Component) {
} else if (key === 'animatedProps') {
Object.keys(value.initial).forEach((key) => {
props[key] = value.initial[key];
if (value.viewRef.current === null) {
value.viewRef.current = this;
}
});
} else if (value instanceof AnimatedEvent) {
// we cannot filter out event listeners completely as some components
Expand Down