Restructure RuntimeDecorator
#1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymon20000
reviewed
Mar 23, 2021
| @@ -16,7 +16,7 @@ void MutableValue::setValue(jsi::Runtime &rt, const jsi::Value &newValue) { | |||
| } | |||
| }; | |||
|
|
|||
| if (module->isUIRuntime(rt)) { | |||
| if (RuntimeDecorator::isWorkletRuntime(rt)) { | |||
There was a problem hiding this comment.
I don't think that RuntimeDecorator should have such methods. Maybe it will fit better with RuntimeManager?
There was a problem hiding this comment.
RuntimeDecorator is the one responsible for marking a runtime a "worklet runtime", why shouldn't it also be exposing a method that can determine this?
There was a problem hiding this comment.
You have convinced me.
piaskowyk
approved these changes
Mar 23, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of 3
RuntimeDecoratorto use the term "Worklet" instead of "UI", and "React Runtime" instead of "Host Runtime".isHostRuntimeandisUIRuntimefromNativeReanimatedModuletoRuntimeDecorator(and make static)