Fix, replace for..of on for loop

[NikitaDudin]

Description

Application crash when using transform or color properties on a style object. Replacing for..of loop on for loop solves it problem.

Issue

• v2.3.0-alpha.1 Tried to synchronously call function {_createForOfIteratorHelperLoose} from a different thread #2120
• Reanimated 2.3.0-alpha.1 error with useAnimatedStyle #2125

[piaskowyk]

Could you provide an example code to reproduce this issue?

[NikitaDudin]

@piaskowyk #1879 (comment)

[mrousavy]

Looks like the JS runtime (or the babel plugin) doesn't whitelist the iterator as a native prop. for..of uses [Symbol.iterator], no?

Maybe is Iterator.next() not whitelisted and REA thinks that function does not exist in the UI JS Runtime, which it does.

[piaskowyk]

Thanks for PR 🙌
Could you just change i += 1 to ++i?

[piaskowyk]

@NikitaDudin which version of babel and Hermes do you use?

[NikitaDudin]

@piaskowyk hermes: 0.7.2 babel: 7.9.0

[NikitaDudin]

Thanks for PR 🙌
Could you just change i += 1 to ++i?

Are you sure me should change to the prefix form ++i? May be i++?

[piaskowyk]

Thanks for PR 🙌
Could you just change i += 1 to ++i?

Are you sure me should change to the prefix form ++i? May be i++?

Yes, ++i is a little faster than i++ and i++ is faster than i += 1 😅. Sure it can depend on the runtime version, but general idea is that. I think that every above expression is the same readable, but if we can choose faster - why not - what do you think? 🤔

[piaskowyk]

I generally don't pick on things like that because this doesn't make a big difference, but I optimized this part of the code last time and I want to make it as fast as possible. 😅

[piaskowyk]

@NikitaDudin good job, thanks 💪