Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(🐛): Fix Android bug when dealing with string animated values #311
fix(🐛): Fix Android bug when dealing with string animated values #311
Changes from 1 commit
7b573fa
a7f4bf9
c171238
2fe4563
33bab43
0edbd24
72cf896
fbffab5
7979be4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that there's no case when it's
Integer
coz JS's number is serialized toDouble
, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colors can actually be represented as Integer
https://github.com/facebook/react-native/blob/0ee5f68929610106ee6864baa04ea90be0fc5160/Libraries/StyleSheet/__tests__/processColor-test.js
https://github.com/facebook/react-native/blob/0ee5f68929610106ee6864baa04ea90be0fc5160/Libraries/StyleSheet/__tests__/normalizeColor-test.js
https://github.com/facebook/react-native/blob/a4cc519a52882a6b08825ecdb15e1c9411c0197d/ReactCommon/fabric/graphics/platform/cxx/Color.h
Also, in react-native-svg:
https://github.com/react-native-community/react-native-svg/blob/master/lib/extract/extractColor.js#L406-L417
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msand can you check if the latest version of the patch is in order? We now look at the value type instead of its Java instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it's never another map, no?
Boolean
,Number
,Array
andString
are enough.Can we reuse it here https://github.com/kmagiera/react-native-reanimated/pull/311/files#diff-4f72bb0bf303947e60ceb110eb069188R99? It appears to be a similar code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Can it be
Array
though then? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic at https://github.com/kmagiera/react-native-reanimated/pull/311/files#diff-4f72bb0bf303947e60ceb110eb069188R99 seems different, do you think that I can unify both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msand I did not need to use this function in order to make the path animation work on Android. Is it a performance optimization to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wcandillon I think without this the change might go from native to js and back to native, rather than stay native. But, I'm not sure, haven't read the latest source, nor placed any debug breakpoints to test this hypothesis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So yes, animating string like SVG path includes JS trip, but it's ok, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or no, it doesn't. Hmmm, need to check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, yes it's animating with native drivers as well 😅