Update react-native version #340
Conversation
Feat/rn upgrade
android/build.gradle
Outdated
| @@ -27,6 +27,7 @@ repositories { | |||
| // https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/local-cli/templates/HelloWorld/android/build.gradle#L21 | |||
| url "$projectDir/../node_modules/react-native/android" | |||
| } | |||
| google() | |||
| @@ -16,5 +16,3 @@ org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryErro | |||
| # This option should only be used with decoupled projects. More details, visit | |||
| # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects | |||
| # org.gradle.parallel=true | |||
|
|
|||
| android.useDeprecatedNdk=true | |||
There was a problem hiding this comment.
while building example project i noticed:
so decided to remove it
| import android.view.ViewGroup; | ||
|
|
||
| import androidx.annotation.Nullable; | ||
| import androidx.transition.ChangeBounds; | ||
| import androidx.transition.ChangeTransform; |
There was a problem hiding this comment.
I wonder if we will be still able to use in old RN version
There was a problem hiding this comment.
I don't think this will be compatible with the old RN version. However, we can manually write a doc for those who use react-native version below 0.60.
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| presets: ['module:metro-react-native-babel-preset'], | |||
There was a problem hiding this comment.
shouldn't we drop .babelrc then?
There was a problem hiding this comment.
sure, I have removed .babelrc file
| @@ -0,0 +1,49 @@ | |||
| platform :ios, '9.0' | |||
Probably yes, this is breaking change, users with older versions of RN will have to use current stable version or update their projects. There is an option to reverse Jetifier with react-native-bob, so we could support older versions of react-native. |
|
What is the status of this PR @osdnk? I would love to go back to using "official" version without relying on fork |
|
Can’t we use jettifier? |
|
Jetifier is quick and dirty fix for library maitainers that aren't willing to spend much time trying to get AndroidX to work properly. The truth is, AndroidX is replacing Android Support library, and not supporting it (pun not inteded) fully you are just asking for trouble when api changes. Everyone back on RN <0.60 will still be able to use older versions of this package without problems. Updating RN to current version is now easier than ever with tools like upgrade-helper |
|
Thanks for submitting this PR, as I've just merged #395 which covers the migration I'm going to close this one. Thank you for your contribution regardless 🙌 |
I've upgraded react-native to 60.0 in library and example project, next step will be to create bindings and specs for turbo module support.