Ensure global objects initialization for web #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Aug 2, 2022
tomekzaw
approved these changes
Aug 5, 2022
piaskowyk
added a commit
that referenced
this pull request
Aug 17, 2022
The PR with tree shaking moved global objects initialization for web to another file and then imported it into the `index` file (`import './reanimated2/js-reanimated/global';`). However, the Webpack can lazy import modules, but we don't have any call to this module, so global objects were never initialized. Fixes #3355
| in another way, the bundler can remove unused variables. | ||
| */ | ||
| console.error('[Reanimated] Unable to initialize global objects for web.'); | ||
| } |
There was a problem hiding this comment.
Was this change supposed to be applied to the src/index.web.ts file instead?
This was referenced Dec 21, 2022
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description The PR with tree shaking moved global objects initialization for web to another file and then imported it into the `index` file (`import './reanimated2/js-reanimated/global';`). However, the Webpack can lazy import modules, but we don't have any call to this module, so global objects were never initialized. Fixes software-mansion#3355
|
@piaskowyk it does not solve anything since you did not applied the fix to |
|
The |
|
I'm with react-native-reanimated@2.14.4 (last version for Expo SDK 48) and there is the PR's code in |
|
Hello I'm also working with react-native-reanimated@2.14.4 (Expo SDK 48) and the error with |
|
Did you try Reanimated3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR with tree shaking moved global objects initialization for web to another file and then imported it into the
indexfile (import './reanimated2/js-reanimated/global';). However, the Webpack can lazy import modules, but we don't have any call to this module, so global objects were never initialized.Fixes #3355