Return null instead of undefined from measure on Fabric
#3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Sep 29, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Oct 6, 2022
This PR removes error `Cannot read property 'x' of undefined` when using `measure` function. For details, see changes. Follow-up of #3598 and #3453. References: * https://github.com/facebook/react-native/blob/278dad6438eac8358a6caaf9dc3b192c0b6137e2/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp#L557-L560 – `measure` * https://github.com/facebook/react-native/blob/8bd3edec88148d0ab1f225d2119435681fbbba33/ReactCommon/react/renderer/core/LayoutMetrics.h#L63-L69 – `EmptyLayoutMetrics` * Changed the return value of native measure function from `undefined` to `null` in case of empty layout metrics * Fixed type of `_measure` function in `globals.d.ts` * Added appropriate variant of warning message in case of empty layout metrics * Added missing spaces in other warning message in `measure` function * Updated Article Progress Example Tested on FabricExample app with Article Progress Example.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…re-mansion#3622) ## Description This PR removes error `Cannot read property 'x' of undefined` when using `measure` function. For details, see changes. Follow-up of software-mansion#3598 and software-mansion#3453. References: * https://github.com/facebook/react-native/blob/278dad6438eac8358a6caaf9dc3b192c0b6137e2/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp#L557-L560 – `measure` * https://github.com/facebook/react-native/blob/8bd3edec88148d0ab1f225d2119435681fbbba33/ReactCommon/react/renderer/core/LayoutMetrics.h#L63-L69 – `EmptyLayoutMetrics` ## Changes * Changed the return value of native measure function from `undefined` to `null` in case of empty layout metrics * Fixed type of `_measure` function in `globals.d.ts` * Added appropriate variant of warning message in case of empty layout metrics * Added missing spaces in other warning message in `measure` function * Updated Article Progress Example ## Test code and steps to reproduce Tested on FabricExample app with Article Progress Example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes error
Cannot read property 'x' of undefinedwhen usingmeasurefunction. For details, see changes.Follow-up of #3598 and #3453.
References:
measureEmptyLayoutMetricsChanges
undefinedtonullin case of empty layout metrics_measurefunction inglobals.d.tsmeasurefunctionTest code and steps to reproduce
Tested on FabricExample app with Article Progress Example.