Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradle task order #3677

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix gradle task order #3677

merged 1 commit into from
Oct 17, 2022

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Oct 14, 2022 •
edited
Loading

Description

Fix for the building issue:

  ../../../../src/main/cpp/AndroidScheduler.h:3:10: fatal error: 'fbjni/fbjni.h' file not found
  #include <fbjni/fbjni.h>

CI fail: https://github.com/piaskowyk/reanimated-rn-version-tester/actions/runs/3250602268/jobs/5334494271

Solution:
We need to execute our tasks before generateJsonModel because in this step FBJNI's headers should be unpacked in the proper location. Same as here:

react-native-reanimated/android/build.gradle

Lines 995 to 997 in 376730e

} else if (JS_RUNTIME == "v8") {
def buildTasks = tasks.findAll({ task ->
!task.name.contains("Clean") && (task.name.contains("externalNative") || task.name.contains("CMake") || task.name.startsWith("generateJsonModel")) })

@piaskowyk piaskowyk requested a review from tomekzaw October 17, 2022 09:01
@piaskowyk piaskowyk marked this pull request as ready for review October 17, 2022 09:01
tomekzaw
tomekzaw approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piaskowyk piaskowyk merged commit 1cede2b into main Oct 17, 2022
@piaskowyk piaskowyk deleted the @piaskowyk/fix-gradle-task-order branch October 17, 2022 09:39
piaskowyk added a commit that referenced this pull request Oct 17, 2022
@piaskowyk
Fix gradle task order (#3677)
3709325 
## Description

Fix for the building issue:
```
  ../../../../src/main/cpp/AndroidScheduler.h:3:10: fatal error: 'fbjni/fbjni.h' file not found
  #include <fbjni/fbjni.h>
```
CI fail:
https://github.com/piaskowyk/reanimated-rn-version-tester/actions/runs/3250602268/jobs/5334494271

Solution:
We need to execute our tasks before `generateJsonModel` because in this
step FBJNI's headers should be unpacked in the proper location. Same as
here:
https://github.com/software-mansion/react-native-reanimated/blob/376730edb6dc2b610553a0ce87ba7040031e422b/android/build.gradle#L995-L997
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@piaskowyk @fluiddot
Fix gradle task order (software-mansion#3677)
46302b3 
## Description

Fix for the building issue:
```
  ../../../../src/main/cpp/AndroidScheduler.h:3:10: fatal error: 'fbjni/fbjni.h' file not found
  #include <fbjni/fbjni.h>
```
CI fail:
https://github.com/piaskowyk/reanimated-rn-version-tester/actions/runs/3250602268/jobs/5334494271

Solution:
We need to execute our tasks before `generateJsonModel` because in this
step FBJNI's headers should be unpacked in the proper location. Same as
here:
https://github.com/software-mansion/react-native-reanimated/blob/376730edb6dc2b610553a0ce87ba7040031e422b/android/build.gradle#L995-L997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piaskowyk @tomekzaw