Detect changes in Podfile.lock #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
force-pushed
the
@tomekzaw/detect-podfile-changes
branch
2 times, most recently
from
90bcd8f to
9e01ccd
Compare
tomekzaw
force-pushed
the
@tomekzaw/detect-podfile-changes
branch
3 times, most recently
from
9144640 to
9e6bcf3
Compare
tomekzaw
force-pushed
the
@tomekzaw/detect-podfile-changes
branch
from
5f5a779 to
4d6e443
Compare
hannojg
added a commit
to margelo/expensify-app-fork
that referenced
this pull request
Oct 25, 2022
software-mansion/react-native-reanimated#3701 Only applied parts, because on REA's main branch the ios project setup changed a bit so i needed to only use whats necessary for the current setup.\ This part of the patch can be reverted once the PR landed and we updated the REA version
piaskowyk
approved these changes
Oct 26, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Oct 26, 2022
Fixes #3696. When compiling Reanimated 3.0.0-rc.3+ for iOS, we need to import `RuntimeAdapter.h`. This file exists in two locations: ``` $ find . -name RuntimeAdapter.h ./node_modules/react-native/ReactCommon/hermes/inspector/RuntimeAdapter.h ./ios/Pods/Headers/Private/React-hermes/reacthermes/RuntimeAdapter.h ``` For some reason I can't remember we couldn't use the instance from `Pods/Headers/Private`. So we need to use the one from node_modules and add `node_modules/react-native/ReactCommon` to `HEADER_SEARCH_PATHS`. When running `pod install`, CocoaPods generates `RNReanimated.podspec.json`. The content of this file affects the checksum (md5 hash) of `RNReanimated` in `Podfile.lock`. Currently, `HEADER_SEARCH_PATHS` contains the absolute path to `ReactCommon` directory. Since the path is absolute, it also contains the project root path, which is different between CI and local development, thus affects the checksum in `Podfile.lock`. This also affects v2 releases as we unified RNReanimated.podspec for 2.x and 3.x. This PR changes the path to `ReactCommon` directory from absolute to relative from `$(PODS_ROOT)` which can be obtained as `Pod::Config.instance.project_pods_root` in Podspec. Another option is to `#import <React-hermes/reacthermes/RuntimeAdapter.h>` instead of `<hermes/inspector/RuntimeAdapter.h>` and entirely remove path to `ReactCommon` directory from `HEADER_SEARCH_PATHS`. Checked on a fresh RN 0.65.2 app with Reanimated installed from package.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description Fixes software-mansion#3696. When compiling Reanimated 3.0.0-rc.3+ for iOS, we need to import `RuntimeAdapter.h`. This file exists in two locations: ``` $ find . -name RuntimeAdapter.h ./node_modules/react-native/ReactCommon/hermes/inspector/RuntimeAdapter.h ./ios/Pods/Headers/Private/React-hermes/reacthermes/RuntimeAdapter.h ``` For some reason I can't remember we couldn't use the instance from `Pods/Headers/Private`. So we need to use the one from node_modules and add `node_modules/react-native/ReactCommon` to `HEADER_SEARCH_PATHS`. When running `pod install`, CocoaPods generates `RNReanimated.podspec.json`. The content of this file affects the checksum (md5 hash) of `RNReanimated` in `Podfile.lock`. Currently, `HEADER_SEARCH_PATHS` contains the absolute path to `ReactCommon` directory. Since the path is absolute, it also contains the project root path, which is different between CI and local development, thus affects the checksum in `Podfile.lock`. This also affects v2 releases as we unified RNReanimated.podspec for 2.x and 3.x. This PR changes the path to `ReactCommon` directory from absolute to relative from `$(PODS_ROOT)` which can be obtained as `Pod::Config.instance.project_pods_root` in Podspec. Another option is to `#import <React-hermes/reacthermes/RuntimeAdapter.h>` instead of `<hermes/inspector/RuntimeAdapter.h>` and entirely remove path to `ReactCommon` directory from `HEADER_SEARCH_PATHS`. Checked on a fresh RN 0.65.2 app with Reanimated installed from package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3696.
When compiling Reanimated 3.0.0-rc.3+ for iOS, we need to import
RuntimeAdapter.h. This file exists in two locations:For some reason I can't remember we couldn't use the instance from
Pods/Headers/Private. So we need to use the one from node_modules and addnode_modules/react-native/ReactCommontoHEADER_SEARCH_PATHS.When running
pod install, CocoaPods generatesRNReanimated.podspec.json. The content of this file affects the checksum (md5 hash) ofRNReanimatedinPodfile.lock.Currently,
HEADER_SEARCH_PATHScontains the absolute path toReactCommondirectory. Since the path is absolute, it also contains the project root path, which is different between CI and local development, thus affects the checksum inPodfile.lock. This also affects v2 releases as we unified RNReanimated.podspec for 2.x and 3.x.This PR changes the path to
ReactCommondirectory from absolute to relative from$(PODS_ROOT)which can be obtained asPod::Config.instance.project_pods_rootin Podspec.Another option is to
#import <React-hermes/reacthermes/RuntimeAdapter.h>instead of<hermes/inspector/RuntimeAdapter.h>and entirely remove path toReactCommondirectory fromHEADER_SEARCH_PATHS.Checked on a fresh RN 0.65.2 app with Reanimated installed from package.