Ignore layout animation props on web #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Oct 26, 2022
piaskowyk
deleted the
@tomekzaw/fix-web-layout-animation-repository-undefined
branch
piaskowyk
pushed a commit
that referenced
this pull request
Oct 26, 2022
## Description Fixes #3464. Currently, Layout Animations are implemented only on Android and iOS. Using `Animated.View` with `entering`, `layout` or `exiting` prop on web should be a no-op, but instead it throws the following error: ``` TypeError: e.LayoutAnimationRepository is undefined t createAnimatedComponent.js:151 setLocalRef createAnimatedComponent.js:149 default setAndForwardRef.js:7 r index.js:22 ``` In this PR I've changed the implementation of `createAnimatedComponent` to disable configuration of layout animation on web, in particular to avoid calling `global.LayoutAnimationRepository.registerConfig(tag, config);`.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description Fixes software-mansion#3464. Currently, Layout Animations are implemented only on Android and iOS. Using `Animated.View` with `entering`, `layout` or `exiting` prop on web should be a no-op, but instead it throws the following error: ``` TypeError: e.LayoutAnimationRepository is undefined t createAnimatedComponent.js:151 setLocalRef createAnimatedComponent.js:149 default setAndForwardRef.js:7 r index.js:22 ``` In this PR I've changed the implementation of `createAnimatedComponent` to disable configuration of layout animation on web, in particular to avoid calling `global.LayoutAnimationRepository.registerConfig(tag, config);`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3464.
Currently, Layout Animations are implemented only on Android and iOS.
Using
Animated.Viewwithentering,layoutorexitingprop on web should be a no-op, but instead it throws the following error:In this PR I've changed the implementation of
createAnimatedComponentto disable configuration of layout animation on web, in particular to avoid callingglobal.LayoutAnimationRepository.registerConfig(tag, config);.