[Layout Animations][iOS] Fix registering exiting view ancestors #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Dec 14, 2022
jwajgelt
deleted the
@jwajgelt/layout_animations_register_ancestors_ios
branch
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…ware-mansion#3849) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> software-mansion#3824 introduces a bug with how we register ancestors of views with `exiting` animations. When a tree with `exiting` views is reattached to the native view hierarchy, we don't register the ancestors of that tree as ancestors of exiting subviews. This may cause issues with deleting these views early, while there're still `exiting` animations running inside them. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#3824 introduces a bug with how we register ancestors of views with
exitinganimations.When a tree with
exitingviews is reattached to the native view hierarchy, we don't register the ancestors of that tree as ancestors of exiting subviews. This may cause issues with deleting these views early, while there're stillexitinganimations running inside them.Test plan