Remove _setGloalConsole JSI method #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Dec 12, 2022
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
kmagiera
added a commit
that referenced
this pull request
Dec 13, 2022
After #3838 we can now access the main global object via `global` variable. This eliminates a need for _setGlobalConsole JSI method that we'd install in the UI runtime only so that we can set the console object as global on the UI runtime. In this PR we change the call to _setGlobalConsole with just reassigning global.console. Add some logs in worklets, run the app, see the logs appear on the output, also that console.warn displays in the log box. Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
4 tasks
4 tasks
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary After software-mansion#3838 we can now access the main global object via `global` variable. This eliminates a need for _setGlobalConsole JSI method that we'd install in the UI runtime only so that we can set the console object as global on the UI runtime. In this PR we change the call to _setGlobalConsole with just reassigning global.console. ## Test plan Add some logs in worklets, run the app, see the logs appear on the output, also that console.warn displays in the log box. Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #3838 we can now access the main global object via
globalvariable. This eliminates a need for _setGlobalConsole JSI method that we'd install in the UI runtime only so that we can set the console object as global on the UI runtime. In this PR we change the call to _setGlobalConsole with just reassigning global.console.Test plan
Add some logs in worklets, run the app, see the logs appear on the output, also that console.warn displays in the log box.