Optimize hot code-paths in uAS #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Feb 6, 2023
|
I think this error was fixed in f156b12 – can I get this approved then 🙏 |
tomekzaw
approved these changes
Feb 16, 2023
piaskowyk
approved these changes
Feb 16, 2023
kmagiera
added a commit
that referenced
this pull request
Feb 16, 2023
kmagiera
added a commit
that referenced
this pull request
Feb 17, 2023
## Summary This PR replaces implementation of shallowEqual – it turns out that the new one despite using Object.keys is 20x faster on hermes (haven't checked JSC). Apparently JIT makes it very hard to measure but the difference can be easily noticed when running examples with gestures e.g., snap and drag. ## Test plan Run snap & drag example on emulator on iOS – with the new implementation it does not stutter.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This is another attempt at optimizing useAnimatedStyle and style updater after software-mansion#3950 got reverted. In this approach we omit Object.assign completely in favor of just using newValues object. Since newValues may contain animation objects, we use one of the initial loops from the updater to extract non-animated-props such that they can be used later on instead of using a call to `filerAnimatedProps`. We also replace `styleDiff` that'd allocate new object by `shallowEqual` that only does comparison. We've been using newValues to update the values anyways and so the diff wasn't used. In addition there was a bug before where we had `if (diff)` check – this wasn't correct as in case there were no changes between the objects, the diff would be an empty object and the check would pass. ## Test plan Tested on a bunch of different examples. Make sure to verify on examples that use animations inside uAS.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…ansion#4059) ## Summary This PR replaces implementation of shallowEqual – it turns out that the new one despite using Object.keys is 20x faster on hermes (haven't checked JSC). Apparently JIT makes it very hard to measure but the difference can be easily noticed when running examples with gestures e.g., snap and drag. ## Test plan Run snap & drag example on emulator on iOS – with the new implementation it does not stutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is another attempt at optimizing useAnimatedStyle and style updater after #3950 got reverted. In this approach we omit Object.assign completely in favor of just using newValues object. Since newValues may contain animation objects, we use one of the initial loops from the updater to extract non-animated-props such that they can be used later on instead of using a call to
filerAnimatedProps. We also replacestyleDiffthat'd allocate new object byshallowEqualthat only does comparison. We've been using newValues to update the values anyways and so the diff wasn't used. In addition there was a bug before where we hadif (diff)check – this wasn't correct as in case there were no changes between the objects, the diff would be an empty object and the check would pass.Test plan
Tested on a bunch of different examples. Make sure to verify on examples that use animations inside uAS.