Fix scrollTo on Fabric #4378
Merged
Fix scrollTo on Fabric #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Apr 20, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary The flag `_IS_FABRIC` is only defined on React Runtime, we can't use them on Reanimated Runtime. I removed the check of this flag for Reanimated Runtime because this one prevents any `_dispatchCommand` call. ## Test plan Run any scrollTo example on Fabric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The flag
_IS_FABRICis only defined on React Runtime, we can't use them on Reanimated Runtime. I removed the check of this flag for Reanimated Runtime because this one prevents any_dispatchCommandcall.Test plan
Run any scrollTo example on Fabric